[PATCH v2] dmadev: add tracepoints
Morten Brørup
mb at smartsharesystems.com
Fri Apr 14 14:46:51 CEST 2023
> From: Chengwen Feng [mailto:fengchengwen at huawei.com]
> Sent: Friday, 14 April 2023 11.09
>
> Add tracepoints at important APIs for tracing support.
>
> Signed-off-by: Chengwen Feng <fengchengwen at huawei.com>
>
> ---
> v2: Address Morten's comment:
> Make stats_get as fast-path trace-points.
> Place fast-path trace-point functions behind in version.map.
...
> +RTE_TRACE_POINT(
> + rte_dma_trace_vchan_status,
rte_dma_trace_vchan_status should also be a FP trace point.
> + RTE_TRACE_POINT_ARGS(int16_t dev_id, uint16_t vchan,
> + enum rte_dma_vchan_status *status, int ret),
> + int vchan_status = *status;
> + rte_trace_point_emit_i16(dev_id);
> + rte_trace_point_emit_u16(vchan);
> + rte_trace_point_emit_int(vchan_status);
> + rte_trace_point_emit_int(ret);
> +)
> +
> +RTE_TRACE_POINT(
> + rte_dma_trace_dump,
> + RTE_TRACE_POINT_ARGS(int16_t dev_id, FILE *f, int ret),
> + rte_trace_point_emit_i16(dev_id);
> + rte_trace_point_emit_ptr(f);
> + rte_trace_point_emit_int(ret);
> +)
> +
> +/* Fast path trace points */
Don't add the fast path trace points here. Add them to the rte_dmadev_trace_fp.h file.
> +
> +/* Called in loop in examples/dma */
> +RTE_TRACE_POINT_FP(
> + rte_dma_trace_stats_get,
> + RTE_TRACE_POINT_ARGS(int16_t dev_id, uint16_t vchan,
> + struct rte_dma_stats *stats, int ret),
> + rte_trace_point_emit_i16(dev_id);
> + rte_trace_point_emit_u16(vchan);
> + rte_trace_point_emit_u64(stats->submitted);
> + rte_trace_point_emit_u64(stats->completed);
> + rte_trace_point_emit_u64(stats->errors);
> + rte_trace_point_emit_int(ret);
> +)
With those two fixes, you may add:
Acked-by: Morten Brørup <mb at smartsharesystems.com>
More information about the dev
mailing list