[PATCH v2 03/14] net/bnxt: log a message when multicast promisc mode changes

[Ajit Khaparde]

On Sun, Dec 10, 2023 at 9:56 AM Stephen Hemminger
<stephen at networkplumber.org> wrote:
>
> On Sat,  9 Dec 2023 17:24:44 -0800
> Ajit Khaparde <ajit.khaparde at broadcom.com> wrote:
>
> > +             PMD_DRV_LOG(INFO, "Number of Mcast MACs added (%d) exceeded Max supported (%d)\n",
> > +                         nb_mc_addr, BNXT_MAX_MC_ADDRS);
>
> Use %u for unsigned variables.
Ok. Sure. We will update it in v3.

>
>
> > +             PMD_DRV_LOG(INFO, "Turning on Mcast promiscuous mode\n");
>
> Do you really need two log lines.
For the dev team, even one is enough.
The field team thinks two is more clear.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4218 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://mails.dpdk.org/archives/dev/attachments/20231210/04074ba4/attachment.bin>