[PATCH v3 1/6] common/idpf: add hw statistics
Liu, Mingxia
mingxia.liu at intel.com
Wed Feb 1 13:34:36 CET 2023
> -----Original Message-----
> From: Wu, Jingjing <jingjing.wu at intel.com>
> Sent: Wednesday, February 1, 2023 4:49 PM
> To: Liu, Mingxia <mingxia.liu at intel.com>; dev at dpdk.org
> Cc: Xing, Beilei <beilei.xing at intel.com>
> Subject: RE: [PATCH v3 1/6] common/idpf: add hw statistics
>
> > @@ -327,6 +407,11 @@ idpf_dev_start(struct rte_eth_dev *dev)
> > goto err_vport;
> > }
> >
> > + if (idpf_dev_stats_reset(dev)) {
> > + PMD_DRV_LOG(ERR, "Failed to reset stats");
> > + goto err_vport;
>
> If stats reset fails, will block the start process and roll back? I think print ERR
> may be enough.
>
[Liu, Mingxia] Good idea, I'll delete the error process of rolling back.
> > + }
> > +
> > vport->stopped = 0;
> >
> > return 0;
> > @@ -606,6 +691,8 @@ static const struct eth_dev_ops idpf_eth_dev_ops
> = {
> > .tx_queue_release = idpf_dev_tx_queue_release,
> > .mtu_set = idpf_dev_mtu_set,
> > .dev_supported_ptypes_get = idpf_dev_supported_ptypes_get,
> > + .stats_get = idpf_dev_stats_get,
> > + .stats_reset = idpf_dev_stats_reset,
> > };
> >
> > static uint16_t
> > --
> > 2.25.1
More information about the dev
mailing list