[PATCH] app/dumpcap: don't pass negative value to strerror() on error
Stephen Hemminger
stephen at networkplumber.org
Tue Feb 7 18:00:50 CET 2023
If eth_stats_get fails (for example with -ENOTSUPP) then
dumpcap would pass that to strerror which is incorrect.
Fixes: 8744f84bb255 ("app/dumpcap: add statistics mode")
Coverity issue: 383136
Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
---
app/dumpcap/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c
index 904eb5a7d7d9..64294bbfb3e6 100644
--- a/app/dumpcap/main.c
+++ b/app/dumpcap/main.c
@@ -500,7 +500,7 @@ static void statistics_loop(void)
if (r < 0) {
fprintf(stderr,
"stats_get for port %u failed: %d (%s)\n",
- p, r, strerror(r));
+ p, r, strerror(-r));
return;
}
--
2.39.1
More information about the dev
mailing list