[EXT] Re: [PATCH v1 1/5] mempool: remove internal tracepoints from version map

[Jerin Jacob]

On Fri, Feb 10, 2023 at 12:30 PM Ankur Dwivedi <adwivedi at marvell.com> wrote:
>
> >On Thu, Feb 9, 2023 at 7:00 PM Ankur Dwivedi <adwivedi at marvell.com>
> >wrote:
> >>
> >> The file rte_mempool_trace.h contains tracepoints which are internal
> >> to the mempool library. This file is renamed to mempool_trace.h, and
> >> is made an internal header. The tracepoints in this file are removed
> >> from the experimental section in version.map file.
> >>
> >> Signed-off-by: Ankur Dwivedi <adwivedi at marvell.com>
> >
> >> @@ -47,22 +47,8 @@ EXPERIMENTAL {
> >>         __rte_mempool_trace_generic_get;
> >>         __rte_mempool_trace_get_bulk;
> >>         __rte_mempool_trace_get_contig_blocks;
> >
> >I think, FP ones also can be removed.
>
> The FP symbols are used in header file rte_mempool.h. Removing the symbols will cause build
> failure in shared build.

OK. Please update the below note documentation only for FP symbols then.

> >
> >Also, in one of the patch(may be eal). Update the doc
> >https://urldefense.proofpoint.com/v2/url?u=https-
> >3A__doc.dpdk.org_guides_prog-5Fguide_trace-
> >5Flib.html&d=DwIBaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=ILjiNF3GF25y6QdHZU
> >xMl6JrStU0MIuCtO5dMzn3Ybk&m=wr975-
> >STqC3Y1eiGa9KZMdPdNKingEIEfZXvMkri8VO0p31eWWzr8kAoQC2TEIxV&s=g_
> >M3SEGmHvisHLnOLO8ilDQbVQ85MFRR2YCmCfYZ3SE&e=
> >
> >The following note can be removed:
> >
> >The RTE_TRACE_POINT_REGISTER defines the placeholder for the
> >rte_trace_point_t tracepoint object. The user must export a
> >__<trace_function_name> symbol in the library .map file for this tracepoint to
> >be used out of the library, in shared builds. For example, __app_trace_string
> >will be the exported symbol in the above example.
> >
> >
> >
> >> -       __rte_mempool_trace_create;
> >> -       __rte_mempool_trace_create_empty;
> >> -       __rte_mempool_trace_free;
> >> -       __rte_mempool_trace_populate_iova;
> >> -       __rte_mempool_trace_populate_virt;
> >> -       __rte_mempool_trace_populate_default;
> >> -       __rte_mempool_trace_populate_anon;
> >> -       __rte_mempool_trace_cache_create;
> >> -       __rte_mempool_trace_cache_free;
> >>         __rte_mempool_trace_default_cache;
> >> -       __rte_mempool_trace_get_page_size;
> >>         __rte_mempool_trace_cache_flush;
> >> -       __rte_mempool_trace_ops_populate;
> >> -       __rte_mempool_trace_ops_alloc;
> >> -       __rte_mempool_trace_ops_free;
> >> -       __rte_mempool_trace_set_ops_byname;
> >>  };
> >>
> >>  INTERNAL {
> >> --
> >> 2.25.1
> >>