[PATCH v2 4/5] ethdev: remove internal tracepoints from version map

David Marchand david.marchand at redhat.com
Fri Feb 10 15:19:40 CET 2023


On Fri, Feb 10, 2023 at 11:35 AM Ankur Dwivedi <adwivedi at marvell.com> wrote:
>
> The internal tracepoints are removed from the version.map file.
>
> Signed-off-by: Ankur Dwivedi <adwivedi at marvell.com>
> Acked-by: Ferruh Yigit <ferruh.yigit at amd.com>

rte_ethdev_trace.h does not need to be exported.

I suggest the following addition:

diff --git a/lib/ethdev/rte_ethdev_trace.h b/lib/ethdev/ethdev_trace.h
similarity index 96%
rename from lib/ethdev/rte_ethdev_trace.h
rename to lib/ethdev/ethdev_trace.h
index 1491c815c3..3f419fbfa0 100644
--- a/lib/ethdev/rte_ethdev_trace.h
+++ b/lib/ethdev/ethdev_trace.h
@@ -2,8 +2,8 @@
  * Copyright(C) 2020 Marvell International Ltd.
  */

-#ifndef _RTE_ETHDEV_TRACE_H_
-#define _RTE_ETHDEV_TRACE_H_
+#ifndef _ETHDEV_TRACE_H_
+#define _ETHDEV_TRACE_H_

 /**
  * @file
@@ -92,4 +92,4 @@ RTE_TRACE_POINT(
 }
 #endif

-#endif /* _RTE_ETHDEV_TRACE_H_ */
+#endif /* _ETHDEV_TRACE_H_ */
diff --git a/lib/ethdev/ethdev_trace_points.c b/lib/ethdev/ethdev_trace_points.c
index 2919409a15..5f08d2dfb6 100644
--- a/lib/ethdev/ethdev_trace_points.c
+++ b/lib/ethdev/ethdev_trace_points.c
@@ -4,7 +4,7 @@

 #include <rte_trace_point_register.h>

-#include <rte_ethdev_trace.h>
+#include <ethdev_trace.h>

 RTE_TRACE_POINT_REGISTER(rte_ethdev_trace_configure,
        lib.ethdev.configure)
diff --git a/lib/ethdev/meson.build b/lib/ethdev/meson.build
index 39250b5da1..9e97f05983 100644
--- a/lib/ethdev/meson.build
+++ b/lib/ethdev/meson.build
@@ -22,7 +22,6 @@ sources = files(
 headers = files(
         'rte_cman.h',
         'rte_ethdev.h',
-        'rte_ethdev_trace.h',
         'rte_ethdev_trace_fp.h',
         'rte_dev_info.h',
         'rte_flow.h',
diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c
index d25db35f7f..a2d289b7a4 100644
--- a/lib/ethdev/rte_ethdev.c
+++ b/lib/ethdev/rte_ethdev.c
@@ -27,7 +27,7 @@
 #include <rte_ether.h>
 #include <rte_telemetry.h>

-#include "rte_ethdev_trace.h"
+#include "ethdev_trace.h"
 #include "rte_ethdev.h"
 #include "ethdev_driver.h"
 #include "ethdev_profile.h"


-- 
David Marchand



More information about the dev mailing list