[PATCH v2 1/1] eal/linux: reject --huge-dir not parent of mountpt

[John Levon]

On Tue, Jan 03, 2023 at 05:00:30PM -0700, Ashish Sadanandan wrote:

> The code added for allowing --huge-dir to specify hugetlbfs
> sub-directories has a bug where it incorrectly matches mounts that
> contain a prefix of the specified --huge-dir.

Sorry for the trouble & thanks for the fix.

> +		/*
> +		 * Ignore any mount where hugepage_dir is not a parent path of
> +		 * the mount
> +		 */
> +		else if(hugepage_dir_len > mountpt_len &&
> +			internal_conf->hugepage_dir[mountpt_len] != '/') {
>  			continue;
>  		}

Shouldn't this comment say "Ignore any mount that is not a parent path of
hugepage_dir" ?

regards
john