[dpdk-dev] [PATCH] common/cnxk: move ICMP ltype to end of enum

Jerin Jacob jerinjacobk at gmail.com
Mon Jan 9 16:27:58 CET 2023


On Thu, Dec 1, 2022 at 9:33 AM <psatheesh at marvell.com> wrote:
>
> From: Kiran Kumar K <kirankumark at marvell.com>
>
> While configuring the RSS key, mask has been created to match multiple
> ltypes for L4. Since ICMP is placed in between, it is also being
> considered for RSS. So, moving the ICMP to end of enum.
>
> Signed-off-by: Kiran Kumar K <kirankumark at marvell.com>
> Reviewed-by: Jerin Jacob <jerinj at marvell.com>


Applied to dpdk-next-net-mrvl/for-next-net. Thanks


> ---
>  drivers/common/cnxk/hw/npc.h | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/common/cnxk/hw/npc.h b/drivers/common/cnxk/hw/npc.h
> index b8218e25af..4164c6ac2e 100644
> --- a/drivers/common/cnxk/hw/npc.h
> +++ b/drivers/common/cnxk/hw/npc.h
> @@ -219,8 +219,7 @@ enum npc_kpu_lc_ltype {
>  enum npc_kpu_ld_ltype {
>         NPC_LT_LD_TCP = 1,
>         NPC_LT_LD_UDP,
> -       NPC_LT_LD_ICMP,
> -       NPC_LT_LD_SCTP,
> +       NPC_LT_LD_SCTP = 4,
>         NPC_LT_LD_ICMP6,
>         NPC_LT_LD_CUSTOM0,
>         NPC_LT_LD_CUSTOM1,
> @@ -231,6 +230,7 @@ enum npc_kpu_ld_ltype {
>         NPC_LT_LD_NSH,
>         NPC_LT_LD_TU_MPLS_IN_NSH,
>         NPC_LT_LD_TU_MPLS_IN_IP,
> +       NPC_LT_LD_ICMP,
>  };
>
>  enum npc_kpu_le_ltype {
> @@ -276,14 +276,14 @@ enum npc_kpu_lg_ltype {
>  enum npc_kpu_lh_ltype {
>         NPC_LT_LH_TU_TCP = 1,
>         NPC_LT_LH_TU_UDP,
> -       NPC_LT_LH_TU_ICMP,
> -       NPC_LT_LH_TU_SCTP,
> +       NPC_LT_LH_TU_SCTP = 4,
>         NPC_LT_LH_TU_ICMP6,
> +       NPC_LT_LH_CUSTOM0,
> +       NPC_LT_LH_CUSTOM1,
>         NPC_LT_LH_TU_IGMP = 8,
>         NPC_LT_LH_TU_ESP,
>         NPC_LT_LH_TU_AH,
> -       NPC_LT_LH_CUSTOM0 = 0xE,
> -       NPC_LT_LH_CUSTOM1 = 0xF,
> +       NPC_LT_LH_TU_ICMP = 0xF,
>  };
>
>  enum npc_kpu_lb_uflag {
> --
> 2.35.3
>


More information about the dev mailing list