[PATCH v3 3/3] test/bitcount: add bitcount tests

Tyler Retzlaff roretzla at linux.microsoft.com
Mon Jan 9 17:57:32 CET 2023


On Sat, Jan 07, 2023 at 09:15:27AM +0100, Thomas Monjalon wrote:
> 06/01/2023 23:01, Tyler Retzlaff:
> > basic unit test of following functions
> > 
> >     rte_clz32
> >     rte_clz64
> >     rte_ctz32
> >     rte_ctz64
> 
> This can be squashed with implementation in previous patch.
> 
> 

if you mean squashed into the patch that moves the existing functions
sure it can be, but really the addtions are a self contained change
separate from the move of the existing functions.

ordinarily i'd rather see history order be as follows.

- here is a change that just moves code (no addtions no deletions).
- here is a change that adds new apis (no moves).

you sure you want the move and additions all combined into one change?

either way confirm what you want and if needed i'll combine and push a
v4.

thanks


More information about the dev mailing list