[PATCH] Intel iavf: Return in the case of ADD/DEL ETH address

Vipin P R vipinp at vmware.com
Fri Jan 13 14:19:23 CET 2023


In case of i40vf, VIRTCHNL_OP_DEL_ETH_ADDR and VIRTCHNL_OP_ADD_ETH_ADDR are unsupported.
i40evf_execute_vf_cmd is invoked with these operations as part of i40evf_set_mc_addr_list()

The cases are not handled in i40evf_execute_vf_cmd() thus hitting the default case.
There is a retry logic of upto 200 times (2000 in iavf) with a delay of 10ms (1ms in iavf).
This results in a needless delay of 2s in the init phase for each VNIC.

The patch aims to rectify that delay.
In fe2a571c70cc397f2ad4e280f8d084148fea5d62, i40e_ethdev_vf.c was deleted. Hence adding this in iavf_vchnl.c.

Cc: stable at dpdk.org

Signed-off-by: Vipin P R <vipinp at vmware.com>
---
 drivers/net/iavf/iavf_vchnl.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c
index f92daf9..e2f65f5 100644
--- a/drivers/net/iavf/iavf_vchnl.c
+++ b/drivers/net/iavf/iavf_vchnl.c
@@ -367,6 +367,14 @@ iavf_execute_vf_cmd(struct iavf_adapter *adapter, struct iavf_cmd_info *args,
 		}
 		_clear_cmd(vf);
 		break;
+
+    case VIRTCHNL_OP_ADD_ETH_ADDR:
+    case VIRTCHNL_OP_DEL_ETH_ADDR:
+        PMD_DRV_LOG(WARNING, "OP_{ADD/DEL}_ETH_ADDR unsupported");
+        err = 0;
+        _clear_cmd(vf);
+        break;
+
 	default:
 		/* For other virtchnl ops in running time,
 		 * wait for the cmd done flag.
-- 
2.7.4



More information about the dev mailing list