[PATCH v5 1/2] ethdev: fix ethdev configuration state on reset

Thomas Monjalon thomas at monjalon.net
Wed Jan 18 11:29:55 CET 2023


21/12/2022 03:07, Hanumanth Pothula:
> Presently, on device reset, ethdev configuration state,
> dev_configured, is not reset.
> 
> On device reset, reset ethdev configuration state to make
> sure device reconfiguration happens cleanly.
> 
> Signed-off-by: Hanumanth Pothula <hpothula at marvell.com>

A "Fixes" line is missing to show the root cause and help backports.

> --- a/lib/ethdev/rte_ethdev.c
> +++ b/lib/ethdev/rte_ethdev.c
> @@ -1629,6 +1629,8 @@ rte_eth_dev_reset(uint16_t port_id)
>  			port_id, rte_strerror(-ret));
>  	}
>  	ret = dev->dev_ops->dev_reset(dev);
> +	if (!ret)

Should be if (ret == 0)

> +		dev->data->dev_configured = 0;





More information about the dev mailing list