[PATCH RESEND v2 01/11] ethdev: check return result of rte_eth_dev_info_get

Sinan Kaya okaya at kernel.org
Thu Jan 19 06:22:31 CET 2023


On Wed, 2023-01-18 at 09:42 +0100, Thomas Monjalon wrote:
> 22/11/2022 16:30, 
> okaya at kernel.org
> :
> 
> > rte_class_eth: eth_mac_cmp: The status of this call to
> > rte_eth_dev_info_get
> > is not checked, potentially leaving dev_info uninitialized.
> 
> [...]
> 
> >        /* Return 0 if devargs MAC is matching one of the device
> > MACs. */
> > -     rte_eth_dev_info_get(data->port_id, &dev_info);
> > +     if (rte_eth_dev_info_get(data->port_id, &dev_info) < 0)
> > +             return -1;
> > +
> >        for (index = 0; index < dev_info.max_mac_addrs; index++)
> >                if (rte_is_same_ether_addr(&mac, &data-
> > >mac_addrs[index]))
> >                        return 0;
> 
> 
> 
> Acked-by: Thomas Monjalon <
> thomas at monjalon.net
> >
> 
> 

Thanks.

> 
> You would get more attention if you Cc the maintainers.
> 
> You can use this git option: --cc-cmd devtools/get-maintainer.sh

Good to know that we have get-maintainer script.



More information about the dev mailing list