[EXT] Re: [PATCH 1/5] net: add PDCP header

[Thomas Monjalon]

18/01/2023 18:39, Anoob Joseph:
> > 22/12/2022 10:25, Anoob Joseph:
> > > --- /dev/null
> > > +++ b/lib/net/rte_pdcp_hdr.h
> > > @@ -0,0 +1,93 @@
> > > +/* SPDX-License-Identifier: BSD-3-Clause
> > > + * Copyright(C) 2022 Marvell.
> > > + */
> > > +
> > > +#ifndef _RTE_PDCP_HDR_H_
> > > +#define _RTE_PDCP_HDR_H_
> > 
> > No need of extra underscores before and after.
> 
> [Anoob] I was following the example quoted in https://doc.dpdk.org/guides/contributing/coding_style.html.

Oh thanks for the reference, I will fix it.

> Also, other files such as rte_esp.h, rte_udp.h, etc. follow the same.

Some other files don't have underscores.

> Isn't it better to have a uniform coding style?

No really I prefer no underscores,
they are supposed to be used for standard libraries.