[PATCH v4 2/2] ethdev: add quota flow action and item

[Thomas Monjalon]

19/01/2023 10:13, Gregory Etelson:
> Hello Thomas,
> 
> > Is this patch related to query/update of indirect flow action?
> > It looks like it should be in a separate series.
> > 
> 
> Quota flow action updates relay on rte_flow_action_handle_query_update().
> Also, the function is used in the testmd patch section.

Yes we still don't have the tool in CI to mark series dependency.


> > > +     /**
> > > +      * Apply quota verdict - PASS or BLOCK to a flow.
> > 
> > Is "to" really wanted here?
> > What about "pass or block a flow"?
> > 
> 
> The flow action provides information only - it does not affect flow in any way.
> Application needs to match on quota flow item after quota action to discover quota state.
> It's also up to application how to react on quota state. 

I am still not sure to understand the comment.
Is this one better?
"Apply the quota verdict (PASS or BLOCK) to a flow."


> > > +struct rte_flow_action_quota {
> > > +     enum rte_flow_quota_mode mode; /** quota operational mode */
> > > +     int64_t quota;                 /** quota value */
> > 
> > What means a negative quota?
> 
> Negative quota is kind of a loan extended by a hardware if it provides such option.
> If quota value is -T, application must provide at least (T+1) tokens to return quota to PASS state. 

OK. Is it documented?