[EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation

[Hanumanth Reddy Pothula]

> -----Original Message-----
> From: Thomas Monjalon <thomas at monjalon.net>
> Sent: Wednesday, January 18, 2023 4:03 PM
> To: Hanumanth Reddy Pothula <hpothula at marvell.com>
> Cc: Aman Singh <aman.deep.singh at intel.com>; Yuying Zhang
> <yuying.zhang at intel.com>; dev at dpdk.org;
> andrew.rybchenko at oktetlabs.ru; viacheslavo at nvidia.com; Jerin Jacob
> Kollanukkaran <jerinj at marvell.com>; Nithin Kumar Dabilpuram
> <ndabilpuram at marvell.com>; david.marchand at redhat.com
> Subject: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process
> Rx metadata negotiation
> 
> External Email
> 
> ----------------------------------------------------------------------
> 21/12/2022 03:07, Hanumanth Pothula:
> > Presently, Rx metadata is sent to PMD by default, leading to a
> > performance drop as processing for the same in Rx path takes extra
> > cycles.
> >
> > Hence, add new testpmd command,
> >   'enable port <port_id> nic_to_pmd_rx_metadata'
> >
> > This command helps in sending Rx metadata to PMD and thereby Rx
> > metadata flow command requests are processed.
> >
> > Signed-off-by: Hanumanth Pothula <hpothula at marvell.com>
> 
> As said in previous versions, please don't add such option in testpmd.
> The problem is somewhere else, probably in your driver.
> You should make sure your driver is not sending metadata if not needed.
> By the way you didn't reply to the last comments on v3 in December.
> 
>
I added following comment on V4,
- As per spec rte_eth_rx_metadata_negotiate() is processed only when dev_configured is set. Hence can't enable(Rx metadata negotiation) automatically when a flow command requests metadata.
- Add new testpmd command to allow NIC to PMD Rx metadata negotiation.

As we can't enable Rx metadata negotiation on fly, introduced new testpmd command to enable Rx metadata negotiation by resetting the ports.