[PATCH v3 01/10] ethdev: check return result of rte_eth_dev_info_get
okaya at kernel.org
okaya at kernel.org
Fri Jan 20 05:41:31 CET 2023
From: Sinan Kaya <okaya at kernel.org>
rte_class_eth: eth_mac_cmp: The status of this call to rte_eth_dev_info_get
is not checked, potentially leaving dev_info uninitialized.
Signed-off-by: Sinan Kaya <okaya at kernel.org>
---
lib/ethdev/rte_class_eth.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/ethdev/rte_class_eth.c b/lib/ethdev/rte_class_eth.c
index 838b3a8f9f..559ce22491 100644
--- a/lib/ethdev/rte_class_eth.c
+++ b/lib/ethdev/rte_class_eth.c
@@ -50,8 +50,10 @@ eth_mac_cmp(const char *key __rte_unused,
if (rte_ether_unformat_addr(value, &mac) < 0)
return -1; /* invalid devargs value */
+ if (rte_eth_dev_info_get(data->port_id, &dev_info) < 0)
+ return -1;
+
/* Return 0 if devargs MAC is matching one of the device MACs. */
- rte_eth_dev_info_get(data->port_id, &dev_info);
for (index = 0; index < dev_info.max_mac_addrs; index++)
if (rte_is_same_ether_addr(&mac, &data->mac_addrs[index]))
return 0;
--
2.25.1
More information about the dev
mailing list