[PATCH v1 1/1] baseband/acc: fix check after deref and dead code
Hernan Vargas
hernan.vargas at intel.com
Fri Jan 20 21:55:53 CET 2023
Fix potential issue of dereferencing a pointer before null check.
Remove null check for value that could never be null.
Coverity issue: 381646, 381631
Fixes: 989dec301a9 ("baseband/acc100: add ring companion address")
Signed-off-by: Hernan Vargas <hernan.vargas at intel.com>
---
drivers/baseband/acc/rte_acc100_pmd.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c
index 0992cb5d1e..a600511f4b 100644
--- a/drivers/baseband/acc/rte_acc100_pmd.c
+++ b/drivers/baseband/acc/rte_acc100_pmd.c
@@ -4106,12 +4106,9 @@ acc100_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data,
int ret, cbm;
struct rte_bbdev_enc_op *op;
- if (q == NULL)
- return 0;
-#ifdef RTE_LIBRTE_BBDEV_DEBUG
- if (unlikely(ops == 0))
+ if (avail == 0)
return 0;
-#endif
+
op = acc_op_tail(q, 0);
if (unlikely(ops == NULL || op == NULL))
return 0;
--
2.37.1
More information about the dev
mailing list