[PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation

Ferruh Yigit ferruh.yigit at amd.com
Tue Jan 24 19:04:22 CET 2023


On 12/21/2022 2:07 AM, Hanumanth Pothula wrote:
> Presently, Rx metadata is sent to PMD by default, leading
> to a performance drop as processing for the same in Rx path
> takes extra cycles.
> 
> Hence, add new testpmd command,
>   'enable port <port_id> nic_to_pmd_rx_metadata'
> 
> This command helps in sending Rx metadata to PMD and thereby
> Rx metadata flow command requests are processed.
> 
> Signed-off-by: Hanumanth Pothula <hpothula at marvell.com>

Hi Hanumanth,

I agree with Thomas for the patch.

'eth_rx_metadata_negotiate_mp()' requests all Rx metadata offloads to be
enabled, but at this stage if there is no flow rule for Rx metadata why
it is consuming extra cycles?

Can you update driver code to process Rx metadata when it is enabled by
application (via 'rte_eth_rx_metadata_negotiate()') AND there is at
least one flow rule for it?


More information about the dev mailing list