[PATCH v4 1/9] eal: annotate spinlock, rwlock and seqlock

David Marchand david.marchand at redhat.com
Thu Jan 26 13:18:40 CET 2023


On Thu, Jan 19, 2023 at 10:50 PM Tyler Retzlaff
<roretzla at linux.microsoft.com> wrote:
> > > we briefly touched on abstracting annotations in another thread. it
> > > would be favorable if annotations were stashed behind macros that could
> > > be expanded for more than just clang/internal/under doxygen to make
> > > available opportunities to use other annotation dialects that may be
> > > compatible.
> >
> > I am open to abstractions.
> > Do you have pointers for an equivalent functionnality in other
> > compilers/tooling?
>
> aye, reference documentation for SALv2 is here.
> https://learn.microsoft.com/en-us/cpp/code-quality/using-sal-annotations-to-reduce-c-cpp-code-defects?view=msvc-170
>
> locking annotations are here.
> https://learn.microsoft.com/en-us/cpp/code-quality/annotating-locking-behavior?view=msvc-170

I had a brief look at it and it seems close to what clang proposes.
I think there would be no issue with my current proposal since SAL
uses function attributes-like syntax for locking.

Do you see anything blocking?

Thanks Tyler.


-- 
David Marchand



More information about the dev mailing list