[PATCH 3/3] build: limit what is built when using MSVC compiler

Tyler Retzlaff roretzla at linux.microsoft.com
Thu Jan 26 18:28:58 CET 2023


On Thu, Jan 26, 2023 at 11:10:26AM +0000, Bruce Richardson wrote:
> On Wed, Jan 25, 2023 at 11:25:07AM -0800, Tyler Retzlaff wrote:
> > Build only kvargs and telemetry when is_ms_compiler.
> > 
> > Signed-off-by: Tyler Retzlaff <roretzla at linux.microsoft.com>
> > ---
> >  lib/meson.build |  7 +++++++
> >  meson.build     | 13 +++++++++----
> >  2 files changed, 16 insertions(+), 4 deletions(-)
> > 
> > diff --git a/lib/meson.build b/lib/meson.build
> > index 82e4666..8e99e21 100644
> <snip>
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -76,11 +76,16 @@ subdir('config')
> >  
> >  # build libs and drivers
> >  subdir('lib')
> > -subdir('drivers')
> >  
> > -# build binaries and installable tools
> > -subdir('usertools')
> > -subdir('app')
> > +if is_ms_compiler
> > +    enabled_apps = []
> > +else
> > +    subdir('drivers')
> > +
> > +    # build binaries and installable tools
> > +    subdir('usertools')
> > +    subdir('app')
> > +endif
> >  
> 
> My own preference here would be to put the checks inside the
> subdirectories, and try and keep the top-level meson.build file clean.
> Would that work ok?

no objection. one clarification request though.

do you mean just for drivers, usertools and app or do you mean for every
lib/<foo> as well?

i'll send up a v2 once i get confirmation.

> 
> >  # build docs
> >  subdir('doc')
> > -- 
> > 1.8.3.1
> > 


More information about the dev mailing list