[PATCH v2 1/2] vhost: fix possible FDs leak

David Marchand david.marchand at redhat.com
Sun Jan 29 10:25:46 CET 2023


On Fri, Jan 27, 2023 at 5:55 PM Maxime Coquelin
<maxime.coquelin at redhat.com> wrote:
>
> On failure, read_vhost_message() only closed the message
> FDs if the header size was unexpected, but there are other
> cases where it is required. For exemple in the case the
> payload size read from the header is greater than the
> expected maximum payload size.
>
> This patch fixes this by closing all messages FDs in all
> error cases.
>
> Fixes: bf472259dde6 ("vhost: fix possible denial of service by leaking FDs")
> Cc: stable at dpdk.org
>
> Signed-off-by: Maxime Coquelin <maxime.coquelin at redhat.com>

Reviewed-by: David Marchand <david.marchand at redhat.com>

We mentionned offlist that the request type can be logged to help with debug.
Do you intend to add this as a follow up patch?


-- 
David Marchand



More information about the dev mailing list