[PATCH] net/sfc: export pick transfer proxy callback to representors

Ivan Malov ivan.malov at arknetworks.am
Tue Jan 31 08:24:44 CET 2023


Currently, the "pick transfer proxy ethdev" callback is only
advertised for non-representor (in example, main PF) ethdevs.
That does not sit well with the original idea of this method,
which is to let applications discover the privileged port to
use for transfer flow management instead of any given ethdev.
Applications trying to leverage this API on sfc representors
receive an error and cannot configure transfer flow offloads.

Fix the problem by exporting the method to representor ports.

Fixes: 26706314d418 ("net/sfc: implement transfer proxy port callback")
Cc: stable at dpdk.org

Signed-off-by: Ivan Malov <ivan.malov at arknetworks.am>
Reviewed-by: Andy Moreton <amoreton at xilinx.com>
Reviewed-by: Viacheslav Galaktionov <Viacheslav.Galaktionov at arknetworks.am>
---
 drivers/net/sfc/sfc_flow.c |  4 ++++
 drivers/net/sfc/sfc_flow.h |  2 ++
 drivers/net/sfc/sfc_repr.c | 10 ++++++++++
 3 files changed, 16 insertions(+)

diff --git a/drivers/net/sfc/sfc_flow.c b/drivers/net/sfc/sfc_flow.c
index fb59abd0b5..2937953959 100644
--- a/drivers/net/sfc/sfc_flow.c
+++ b/drivers/net/sfc/sfc_flow.c
@@ -2806,6 +2806,10 @@ const struct rte_flow_ops sfc_flow_ops = {
 	.pick_transfer_proxy = sfc_flow_pick_transfer_proxy,
 };
 
+const struct rte_flow_ops sfc_repr_flow_ops = {
+	.pick_transfer_proxy = sfc_flow_pick_transfer_proxy,
+};
+
 void
 sfc_flow_init(struct sfc_adapter *sa)
 {
diff --git a/drivers/net/sfc/sfc_flow.h b/drivers/net/sfc/sfc_flow.h
index 12875344b5..2b1e5a2ff6 100644
--- a/drivers/net/sfc/sfc_flow.h
+++ b/drivers/net/sfc/sfc_flow.h
@@ -107,6 +107,8 @@ TAILQ_HEAD(sfc_flow_list, rte_flow);
 
 extern const struct rte_flow_ops sfc_flow_ops;
 
+extern const struct rte_flow_ops sfc_repr_flow_ops;
+
 enum sfc_flow_item_layers {
 	SFC_FLOW_ITEM_ANY_LAYER,
 	SFC_FLOW_ITEM_START_LAYER,
diff --git a/drivers/net/sfc/sfc_repr.c b/drivers/net/sfc/sfc_repr.c
index 417d0073cb..6b1d5492a9 100644
--- a/drivers/net/sfc/sfc_repr.c
+++ b/drivers/net/sfc/sfc_repr.c
@@ -18,6 +18,7 @@
 
 #include "sfc_log.h"
 #include "sfc_debug.h"
+#include "sfc_flow.h"
 #include "sfc_repr.h"
 #include "sfc_ethdev_state.h"
 #include "sfc_repr_proxy_api.h"
@@ -888,6 +889,14 @@ sfc_repr_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
 	return 0;
 }
 
+static int
+sfc_repr_dev_flow_ops_get(struct rte_eth_dev *dev __rte_unused,
+			  const struct rte_flow_ops **ops)
+{
+	*ops = &sfc_repr_flow_ops;
+	return 0;
+}
+
 static const struct eth_dev_ops sfc_repr_dev_ops = {
 	.dev_configure			= sfc_repr_dev_configure,
 	.dev_start			= sfc_repr_dev_start,
@@ -901,6 +910,7 @@ static const struct eth_dev_ops sfc_repr_dev_ops = {
 	.rx_queue_release		= sfc_repr_rx_queue_release,
 	.tx_queue_setup			= sfc_repr_tx_queue_setup,
 	.tx_queue_release		= sfc_repr_tx_queue_release,
+	.flow_ops_get			= sfc_repr_dev_flow_ops_get,
 };
 
 
-- 
2.30.2



More information about the dev mailing list