[PATCH v3 04/28] vhost: add helper of IOTLB entries coredump

Maxime Coquelin maxime.coquelin at redhat.com
Thu Jun 1 15:43:03 CEST 2023



On 5/26/23 10:46, David Marchand wrote:
> On Thu, May 25, 2023 at 6:26 PM Maxime Coquelin
> <maxime.coquelin at redhat.com> wrote:
>> @@ -149,8 +177,8 @@ vhost_user_iotlb_cache_remove_all(struct virtio_net *dev, struct vhost_virtqueue
>>          rte_rwlock_write_lock(&vq->iotlb_lock);
>>
>>          RTE_TAILQ_FOREACH_SAFE(node, &vq->iotlb_list, next, temp_node) {
>> -               mem_set_dump((void *)(uintptr_t)node->uaddr, node->size, false,
>> -                       hua_to_alignment(dev->mem, (void *)(uintptr_t)node->uaddr));
>> +               vhost_user_iotlb_set_dump(dev, node);
> 
> vhost_user_iotlb_clear_dump ?


Yes, good catch!
Will be fixed in v4.

Thanks,
Maxime

> 
>> +
>>                  TAILQ_REMOVE(&vq->iotlb_list, node, next);
>>                  vhost_user_iotlb_pool_put(vq, node);
>>          }
> 
> 



More information about the dev mailing list