[PATCH 00/10] support telemetry query ethdev info

[Ferruh Yigit]

On 5/30/2023 10:05 AM, Jie Hai wrote:
> This patchset supports querying information about ethdev.
> The information includes MAC addresses, RxTx offload, flow ctrl,
> Rx|Tx queue, firmware version, DCB, RSS, FEC, VLAN, etc.
> 
> 
> Dengdui Huang (1):
>   ethdev: support telemetry query MAC addresses
> 
> Jie Hai (9):
>   ethdev: support RxTx offload display
>   ethdev: support telemetry query flow ctrl info
>   ethdev: support telemetry query Rx queue info
>   ethdev: support telemetry query Tx queue info
>   ethdev: add firmware version in telemetry info command
>   ethdev: support telemetry query DCB info
>   ethdev: support telemetry query RSS info
>   ethdev: support telemetry query FEC info
>   ethdev: support telemetry query VLAN info
>

Hi Jie,

Overall it is good to add more telemetry support, but it is making
'rte_ethdev.c' bigger, specially naming of the static functions that
telemetry handlers use making file confusing.
Can you please create a specific file for telemetry functions?

First you can move the existing ones and later add your patches.

Also there is a common part that reads and verifies port_id, I think
that part can be extracted to a common function, I will comment on it in
one of the patches.

Thanks,
ferruh