[PATCH 21/25] net/mlx5: replace snprintf with strlcpy

Stephen Hemminger stephen at networkplumber.org
Thu Jun 1 17:01:02 CEST 2023


Suggested by devtools/cocci/strlcpy-with-header.cocci

Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
---
 drivers/net/mlx5/mlx5_rx.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/net/mlx5/mlx5_rx.c b/drivers/net/mlx5/mlx5_rx.c
index a2be523e9e36..5d0ec51f2a19 100644
--- a/drivers/net/mlx5/mlx5_rx.c
+++ b/drivers/net/mlx5/mlx5_rx.c
@@ -219,26 +219,26 @@ mlx5_rx_burst_mode_get(struct rte_eth_dev *dev,
 		return -rte_errno;
 	}
 	if (pkt_burst == mlx5_rx_burst) {
-		snprintf(mode->info, sizeof(mode->info), "%s", "Scalar");
+		strlcpy(mode->info, "Scalar", sizeof(mode->info));
 	} else if (pkt_burst == mlx5_rx_burst_mprq) {
-		snprintf(mode->info, sizeof(mode->info), "%s", "Multi-Packet RQ");
+		strlcpy(mode->info, "Multi-Packet RQ", sizeof(mode->info));
 	} else if (pkt_burst == mlx5_rx_burst_vec) {
 #if defined RTE_ARCH_X86_64
-		snprintf(mode->info, sizeof(mode->info), "%s", "Vector SSE");
+		strlcpy(mode->info, "Vector SSE", sizeof(mode->info));
 #elif defined RTE_ARCH_ARM64
-		snprintf(mode->info, sizeof(mode->info), "%s", "Vector Neon");
+		strlcpy(mode->info, "Vector Neon", sizeof(mode->info));
 #elif defined RTE_ARCH_PPC_64
-		snprintf(mode->info, sizeof(mode->info), "%s", "Vector AltiVec");
+		strlcpy(mode->info, "Vector AltiVec", sizeof(mode->info));
 #else
 		return -EINVAL;
 #endif
 	} else if (pkt_burst == mlx5_rx_burst_mprq_vec) {
 #if defined RTE_ARCH_X86_64
-		snprintf(mode->info, sizeof(mode->info), "%s", "MPRQ Vector SSE");
+		strlcpy(mode->info, "MPRQ Vector SSE", sizeof(mode->info));
 #elif defined RTE_ARCH_ARM64
-		snprintf(mode->info, sizeof(mode->info), "%s", "MPRQ Vector Neon");
+		strlcpy(mode->info, "MPRQ Vector Neon", sizeof(mode->info));
 #elif defined RTE_ARCH_PPC_64
-		snprintf(mode->info, sizeof(mode->info), "%s", "MPRQ Vector AltiVec");
+		strlcpy(mode->info, "MPRQ Vector AltiVec", sizeof(mode->info));
 #else
 		return -EINVAL;
 #endif
-- 
2.39.2



More information about the dev mailing list