[PATCH v6 3/4] bus/cdx: add support for MSI

[Nipun Gupta]

On 6/6/2023 3:00 PM, David Marchand wrote:
> 
> On Mon, Jun 5, 2023 at 3:27 PM Nipun Gupta <nipun.gupta at amd.com> wrote:
>> +/* set up interrupt support (but not enable interrupts) */
>>   static int
>> -cdx_rte_vfio_setup_device(int vfio_dev_fd)
>> +cdx_vfio_setup_interrupts(struct rte_cdx_device *dev, int vfio_dev_fd,
> 
> I had dropped a bit too much of the hunk in my previous comment, but see below:
> 
> [snip]
> 
>> +static int
>> +cdx_vfio_setup_device(struct rte_cdx_device *dev, int vfio_dev_fd,
>> +               int num_irqs)
> 
> cdx_rte_vfio_setup_device() is renamed to cdx_vfio_setup_device().
> Such a rename is unneeded noise, cdx_vfio_setup_device() should be
> used from the start, in patch1.
> 
> If there is no further comment on the series, I can fix this when applying.

Thanks for pointing. I missed this part. There are some minor changes 
requested by Thomas and I would send out a version today with this 
change you mentioned as well.

Regards,
Nipun

> 
> 
> --
> David Marchand
>