[PATCH] mempool: optimize get objects with constant n

Morten Brørup mb at smartsharesystems.com
Wed Jun 7 10:41:42 CEST 2023


> From: Morten Brørup
> Sent: Wednesday, 7 June 2023 10.34
> 
> > From: Thomas Monjalon [mailto:thomas at monjalon.net]
> > Sent: Wednesday, 7 June 2023 10.10
> >

[...]

> > What about doing a general comment at the top of the function,
> > with the assignment of the pointer at the end of the array:
> >
> >     /* The cache is a stack, so copy will be in reverse order. */
> >     cache_objs = &cache->objs[cache->len];
> >
> > I could do it on apply if there is an agreement.
> >
> ACK from me.
> 
> For consistency, please also add the reminder to the two existing reverse
> order copy loops in rte_mempool_do_generic_get().

Rubbish! I was looking at the wrong version of the code.

So, plain ACK from me. No further comments!

Sorry. :-!



More information about the dev mailing list