[PATCH] net/nfp: fix callback function pointer of disabling promisc

Chaoyong He chaoyong.he at corigine.com
Thu Jun 8 05:07:56 CEST 2023


From: Qin Ke <qin.ke at corigine.com>

The callback function of promiscuous_disable in nfp_flower_pf_repr_dev_ops
and nfp_flower_repr_dev_ops should be nfp_net_promisc_disable, not
nfp_net_promisc_enable, fix it.

Fixes: 39d82d2 ("net/nfp: fix promiscuous mode for representor port")
Cc: Chaoyong He <chaoyong.he at corigine.com>
Cc: stable at dpdk.org

Signed-off-by: Qin Ke <qin.ke at corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he at corigine.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund at corigine.com>
---
 drivers/net/nfp/flower/nfp_flower_representor.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/nfp/flower/nfp_flower_representor.c b/drivers/net/nfp/flower/nfp_flower_representor.c
index 6b4ba5b9a2..3225a4b84a 100644
--- a/drivers/net/nfp/flower/nfp_flower_representor.c
+++ b/drivers/net/nfp/flower/nfp_flower_representor.c
@@ -518,7 +518,7 @@ static const struct eth_dev_ops nfp_flower_pf_repr_dev_ops = {
 	.stats_reset          = nfp_flower_repr_stats_reset,
 
 	.promiscuous_enable   = nfp_net_promisc_enable,
-	.promiscuous_disable  = nfp_net_promisc_enable,
+	.promiscuous_disable  = nfp_net_promisc_disable,
 
 	.mac_addr_set         = nfp_flower_repr_mac_addr_set,
 	.fw_version_get       = nfp_repr_firmware_version_get,
@@ -540,7 +540,7 @@ static const struct eth_dev_ops nfp_flower_repr_dev_ops = {
 	.stats_reset          = nfp_flower_repr_stats_reset,
 
 	.promiscuous_enable   = nfp_net_promisc_enable,
-	.promiscuous_disable  = nfp_net_promisc_enable,
+	.promiscuous_disable  = nfp_net_promisc_disable,
 
 	.mac_addr_set         = nfp_flower_repr_mac_addr_set,
 	.fw_version_get       = nfp_repr_firmware_version_get,
-- 
2.39.1



More information about the dev mailing list