[dpdk-dev] [PATCH 1/3] eal: remove useless checks for already probed device

[Stephen Hemminger]

On Wed, 13 Mar 2019 13:46:01 +0000
"Zhang, Qi Z" <qi.z.zhang at intel.com> wrote:

> > -----Original Message-----
> > From: Thomas Monjalon [mailto:thomas at monjalon.net]
> > Sent: Saturday, March 2, 2019 10:43 AM
> > To: dev at dpdk.org
> > Cc: Stojaczyk, Dariusz <dariusz.stojaczyk at intel.com>; Zhang, Qi Z
> > <qi.z.zhang at intel.com>; stable at dpdk.org
> > Subject: [PATCH 1/3] eal: remove useless checks for already probed device
> > 
> > The function eal_dev_hotplug_request_to_secondary() never returns -EEXIST
> > result. The case of already probed device is filtered out.
> > 
> > The test in __handle_secondary_request() was always true.
> > The test in rte_dev_probe() was never true, and that's fine not returning -EEXIST
> > if device is already attached in secondary processes.  
> 
> I didn't get this.
> eal_dev_hotplug_request_to_secondary() never return -EEXIST, but req->result could be -EEXIST.
> 
> This happens when secondary try to attach an already attached device 
> (__handle_primary_request --> local_dev_probe --> dev->bus->plug )

This seems to be the outstanding question on this old patch.
Is this possible? If so then the original code is ok, and patch is not required.