[dpdk-dev] [PATCH] doc: clarify spaces for alignment note

Stephen Hemminger stephen at networkplumber.org
Mon Jun 12 17:59:11 CEST 2023


On Mon, 11 Mar 2019 18:39:39 +0000
Kevin Traynor <ktraynor at redhat.com> wrote:

> Make clear that spaces are only for alignments less than tab size.
> 
> Signed-off-by: Kevin Traynor <ktraynor at redhat.com>
> ---
>  doc/guides/contributing/coding_style.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/doc/guides/contributing/coding_style.rst b/doc/guides/contributing/coding_style.rst
> index d96698a73..dd7ddc21e 100644
> --- a/doc/guides/contributing/coding_style.rst
> +++ b/doc/guides/contributing/coding_style.rst
> @@ -348,5 +348,5 @@ General
>  .. note::
>  
> -	Global whitespace rule in DPDK, use tabs for indentation, spaces for alignment.
> +	Global whitespace rule in DPDK, use tabs for indentation, spaces for smaller alignments.
>  
>  * Do not put any spaces before a tab for indentation.

Dropping this patch, the wording makes sense but the responses bordered on bike shedding
about white space.

IMHO we should get some automated tools involved (like clang format) to handle whitespace
inconsistency.


More information about the dev mailing list