[dpdk-dev] [PATCH v1 03/17] ethdev: replace library debug flag with global one

[Stephen Hemminger]

On Mon, 20 Apr 2020 19:34:43 +0200
Lukasz Wojciechowski <l.wojciechow at partner.samsung.com> wrote:

> > Note, this means that you need to ensure all debug printouts from libs and
> > drivers are using the RTE_LOG macros so can be runtime controlled. I think
> > that may be some distance from reality right now.
> >
> > Even if we do want all debug enabled from one flag, I'm still not 100%
> > convinced that the existing debug flag is the way to do, since it only adds
> > debug info to binary without affecting code generation.  
> OK, I see that there are different opinions on what shape the debug flag 
> should look like.
> So I think, I'll hold on work on any implementation until we all agree, 
> what do we want.
> 
> @Bruce: What code generation do you have on mind?

This patchset seems stagnated by good intentions but no later effort.
Agree that having:
  - a global flag for all debugs enabled would be good.
  - CI should do a build with that flag turned on.
  
This will check that debug code actually works and is not so verbose that
it can't run (which is often the case now).

But current patchset doesn't do that.  So leaving final disposition
as "Changes requested" and someone can pick it up if they want to continue.