[Bug 1249] [dpdk-23.07] ixgbe port stop failed after launch testpmd

[David Marchand]

Hello,

On Mon, Jun 12, 2023 at 6:32 PM Tyler Retzlaff
<roretzla at linux.microsoft.com> wrote:
> If there has been a broad regression here could I ask for your help in
> either reverting it until I can look at it properly or if you see the
> obvious problem fixing it.
>
> There were multiple instances of flags being converted to bool in the
> series it may be that they all need to be backed out.

I relooked at Tyler series, and I think the net/ixgbe patch is the
only one that has an issue.

It converted:
-    rte_atomic32_t link_thread_running;
+    bool link_thread_running;

IIUC, link_thread_running was used as a kind of refcount before Tyler change.
So rather than revert, I suppose the fix is to move to a uint32_t (and
rename the variable maybe).

ixgbe maintainers, please confirm.


-- 
David Marchand