[PATCH v3] eal: add tracepoints to track lcores and services

[Van Haaren, Harry]

> -----Original Message-----
> From: David Marchand <david.marchand at redhat.com>
> Sent: Tuesday, June 13, 2023 9:39 AM
> To: Arnaud Fiorini <arnaud.fiorini at polymtl.ca>; Van Haaren, Harry
> <harry.van.haaren at intel.com>
> Cc: Thomas Monjalon <thomas at monjalon.net>; Jerin Jacob
> <jerinj at marvell.com>; Sunil Kumar Kori <skori at marvell.com>; dev at dpdk.org
> Subject: Re: [PATCH v3] eal: add tracepoints to track lcores and services
> 
> Hello,

Hi David,

> On Fri, May 12, 2023 at 4:30 PM Arnaud Fiorini
> <arnaud.fiorini at polymtl.ca> wrote:
> >
> > The tracepoints added are used to track lcore role and status,
> > as well as service mapping and service runstates. These
> > tracepoints are then used in analyses in Trace Compass.
> >
> > Signed-off-by: Arnaud Fiorini <arnaud.fiorini at polymtl.ca>
> 
> Harry, the majority of trace points added by this patch are in the service code.
> Could you review please?

Performance wise, this patch is the same as V1 comments, no concerns here just noting that enabling tracing impacts perf.
http://patches.dpdk.org/project/dpdk/patch/20230424152412.3784016-2-arnaud.fiorini@polymtl.ca/#159839

Docs look good, thanks for adding the --trace=  example, it will help users in future!

Acked-by: Harry van Haaren <harry.van.haaren at intel.com>