[RFC 2/5] common/mlx5: introduce tracepoints for mlx5 drivers

[Jerin Jacob]

On Tue, Jun 13, 2023 at 9:20 PM Slava Ovsiienko <viacheslavo at nvidia.com> wrote:
>
> Hi,
>
> <..snip..>
> > >
> > >         mlx5_os_interrupt_handler_create; # WINDOWS_NO_EXPORT
> > >         mlx5_os_interrupt_handler_destroy; # WINDOWS_NO_EXPORT
> > > +
> > > +       __rte_pmd_mlx5_trace_tx_entry;
> > > +       __rte_pmd_mlx5_trace_tx_exit;
> > > +       __rte_pmd_mlx5_trace_tx_wqe;
> > > +       __rte_pmd_mlx5_trace_tx_wait;
> > > +       __rte_pmd_mlx5_trace_tx_push;
> > > +       __rte_pmd_mlx5_trace_tx_complete;
> >
> > No need to expose these symbols. It is getting removed from rest of DPDK.
> > Application can do rte_trace_lookup() to get this address.
> >
> >
> It is not for application, it is for PMD itself, w/o exposing the symbols build failed.

PMD is implementing this trace endpoints, not consuming this trace
point. Right? If so, Why to expose these symbols?

>
> With best regards,
> Slava
>