[PATCH 0/5] cleanup in library header files

David Marchand david.marchand at redhat.com
Wed Jun 14 17:08:03 CEST 2023


On Wed, Jun 14, 2023 at 4:42 PM Jerin Jacob <jerinjacobk at gmail.com> wrote:
>
> On Wed, Jun 14, 2023 at 8:01 PM Thomas Monjalon <thomas at monjalon.net> wrote:
> >
> > While pulling some trees for DPDK 23.07-rc1,
> > I've seen that some wrong coding style for comments
> > were copied over and over.
> >
> > In order to avoid copying wrong comment style,
> > the three first patches are fixing a lot of comments.
> > As it is not critical, they are not marked for backport.
> >
> > While looking the header files, I've fixed some misuses of "extern".
>
> Thanks for the cleanup. IMO, it is better to update
> ./devtools/checkpatches.sh or so to flag these issue before getting to
> repo for new changes,

Those are not easy to spot.
+1 to add a check if that won't raise false positives.


-- 
David Marchand



More information about the dev mailing list