[PATCH] examples/ntb: remove redundant logic for dev close

Ling, WeiX weix.ling at intel.com
Thu Jun 15 10:28:05 CEST 2023


> -----Original Message-----
> From: Junfeng Guo <junfeng.guo at intel.com>
> Sent: Wednesday, June 14, 2023 1:14 PM
> To: Wu, Jingjing <jingjing.wu at intel.com>
> Cc: dev at dpdk.org; stable at dpdk.org; He, Xingguang
> <xingguang.he at intel.com>; Laatz, Kevin <kevin.laatz at intel.com>; Guo,
> Junfeng <junfeng.guo at intel.com>
> Subject: [PATCH] examples/ntb: remove redundant logic for dev close
> 
> During EAL cleanup stage, all bus devices are cleaned up properly.
> Based on this, there is no need to do extra device close process, which may
> call the dev ops '*dev->dev_ops->dev_close' twice.
> 
> If this dev ops for ntb was called twice, the interrupt handle for EAL will be
> disabled twice and will lead to error for the seconde time. Like this: "EAL:
> Error disabling MSI-X interrupts for fd xx"
> 
> Thus, this patch just remove the redundant logic for device close.
> Ports will be closed at rte_eal_cleanup() in the main loop.
> 
> Fixes: 1cab1a40ea9b ("bus: cleanup devices on shutdown")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Junfeng Guo <junfeng.guo at intel.com>
> ---

Tested-by: Wei Ling <weix.ling at intel.com>


More information about the dev mailing list