[EXT] Re: [PATCH v2 8/8] crypto/ipsec_mb: set and use session ID

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: Akhil Goyal <gakhil at marvell.com>
> Sent: Thursday, June 15, 2023 5:47 AM
> To: Fangming Fang <Fangming.Fang at arm.com>; thomas at monjalon.net;
> Power, Ciara <ciara.power at intel.com>; Honnappa Nagarahalli
> <Honnappa.Nagarahalli at arm.com>; Ji, Kai <kai.ji at intel.com>; De Lara Guarch,
> Pablo <pablo.de.lara.guarch at intel.com>; Ruifeng Wang
> <Ruifeng.Wang at arm.com>; Mcnamara, John <john.mcnamara at intel.com>
> Cc: dev at dpdk.org; david.marchand at redhat.com; Jerin Jacob Kollanukkaran
> <jerinj at marvell.com>; Ashwin Sekhar T K <asekhar at marvell.com>
> Subject: RE: [EXT] Re: [PATCH v2 8/8] crypto/ipsec_mb: set and use session ID
> 
> 
> 
> > -----Original Message-----
> > From: Fangming Fang <Fangming.Fang at arm.com>
> > Sent: Thursday, June 15, 2023 8:16 AM
> > To: Akhil Goyal <gakhil at marvell.com>; thomas at monjalon.net; Ciara Power
> > <ciara.power at intel.com>; Honnappa Nagarahalli
> > <Honnappa.Nagarahalli at arm.com>; kai.ji at intel.com; Pablo de Lara
> > <pablo.de.lara.guarch at intel.com>; Ruifeng Wang
> <Ruifeng.Wang at arm.com>;
> > john.mcnamara at intel.com
> > Cc: dev at dpdk.org; david.marchand at redhat.com; Jerin Jacob Kollanukkaran
> > <jerinj at marvell.com>; Ashwin Sekhar T K <asekhar at marvell.com>
> > Subject: RE: [EXT] Re: [PATCH v2 8/8] crypto/ipsec_mb: set and use
> > session ID
> >
> > > From: Akhil Goyal <gakhil at marvell.com>
> > > > 16/05/2023 17:24, Ciara Power:
> > > > > From: Pablo de Lara <pablo.de.lara.guarch at intel.com>
> > > > >
> > > > > When creating a session, get the session ID that defines the
> > > > > fixed session parameters and store it in the private data.
> > > > > When retrieving IMB_JOB's, if their internal session ID matches
> > > > > the one in the private session data, these fixed session
> > > > > parameters do not need to be filled again.
> > > > >
> > > > > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch at intel.com>
> > > > > Signed-off-by: Ciara Power <ciara.power at intel.com>
> > > > [...]
> > > > > +#if IMB_VERSION(1, 3, 0) < IMB_VERSION_NUM
> > > > > + sess->session_id = imb_set_session(mb_mgr,
> > > > > + sess->&sess->template_job);
> > > > > +#endif
> > > >
> > > > For info, this does not compile with
> > > > https://git.gitlab.arm.com/arm-reference-solutions/ipsec-mb
> > > > because Arm did not merge Intel's code correctly, and
> > > > imb_set_session() is missing while version is 1.4.0-dev.
> > > >
> > > > Anyway I hate this situation having 2 repos for the same thing.
> > > > Please merge Arm code in the original repository from Intel.
> > > >
> > > Is it possible to make Arm repo as main repo and modify DPDK
> > > documentation, if Intel not agreeing to include Arm code?
> > > Currently the Arm repo use case is broken.
> > > If it is not resolved soon, we can submit a patch to revert the
> > > patch which is breaking compilation. This need to be fixed by RC2.
> >
> > It would be better if the original repo can merge Arm changes. We will
> > keep regular sync with original repo in the current situation, the
> > next sync will be carried out earlier in Q3.
> 
> Yes, it is better to keep original repo. But if Intel is not agreeing to it, We may
> need to find some alternate way to fix it.
> We need a sync as soon as possible, as with current Arm repo, DPDK
> compilation is broken.
> 
> For now, we cannot merge anything in ipsec_mb driver till we fix the
> compilation With Arm repo - either by Arm repo sync or by reverting the
> patches.

DPDK is supposed to use stable versions of the library (e.g. releases), not top of main branch.
As described in README https://github.com/intel/intel-ipsec-mb#4-package-content, tip of the main is NOT a release software version.
In case of ARM library clone, it is not clear what the latest stable version is.
As the Intel library version is bumped in the first stages of development for the next release, it is advisable to avoid updating this version in ARM library, until a new Intel intel-ipsec-mb version is released.
For now, the simplest solution is to revert the ARM library version to 1.3 (changing IMB_VERSION_NUM and IMB_VERSION_STR), until the ARM repo is synced to Intel 1.4.0 (which has just been released).

> 
> Regards,
> Akhil