[PATCH v3] build: select optional libraries
Bruce Richardson
bruce.richardson at intel.com
Mon Jun 19 16:26:26 CEST 2023
On Mon, Jun 19, 2023 at 04:11:37PM +0200, David Marchand wrote:
> On Fri, Jun 16, 2023 at 9:21 AM David Marchand
> <david.marchand at redhat.com> wrote:
> > @@ -141,13 +137,25 @@ foreach l:libraries
> > deps += ['eal']
> > endif
> >
> > - if disabled_libs.contains(l)
> > + if not enable_libs.contains(l)
> > + build = false
> > + reason = 'not in enabled libraries build config'
> > + elif disable_libs.contains(l)
> > build = false
> > reason = 'explicitly disabled via build config'
> > - if dpdk_libs_deprecated.contains(l)
> > + endif
>
> There is also a change in behavior for current users of the
> -Ddisable_libs= configuration (which was used for enabling deprecated
> libraries, for example).
I notice the change in behaviour for enabling the deprecated libs. Is there
any other change in behaviour for current users?
> My current solution resides in making disable_libs and enable_libs
> options being mutually exclusive (meaning that presence of a value for
> enable_libs will ignore any configuration around disable_libs).
>
> Does it look ok to you?
>
Do we need to make them mutually exclusive? The current drivers
implementation allows them to be used together, I think.
/Bruce
More information about the dev
mailing list