[EXT] [PATCH] common/cnxk/roc_npa: fix npa_aura_fini

[Thierry Herbelot]

Hello Ashwin,

I will resend a patch with a fix also in npa_aura_pool_fini

	Thierry

On 6/20/23 11:27, Ashwin Sekhar T K wrote:
> Hi Thierry,
> 
> Could you please add the same fix in npa_aura_pool_fini() as well.
> 
> Thanks
> Ashwin Sekhar T K
> 
>> -----Original Message-----
>> From: Thierry Herbelot <thierry.herbelot at 6wind.com>
>> Sent: Tuesday, June 20, 2023 2:22 PM
>> To: dev at dpdk.org
>> Cc: Thierry Herbelot <thierry.herbelot at 6wind.com>; Thomas Monjalon
>> <thomas at monjalon.net>; Nithin Kumar Dabilpuram
>> <ndabilpuram at marvell.com>; Satha Koteswara Rao Kottidi
>> <skoteshwar at marvell.com>; Jerin Jacob Kollanukkaran
>> <jerinj at marvell.com>
>> Subject: [EXT] [PATCH] common/cnxk/roc_npa: fix npa_aura_fini
>>
>> External Email
>>
>> ----------------------------------------------------------------------
>> Unlock mbox when an error is detected.
>>
>> Fixes: ea4d70cc4f0b46d5 ('common/cnxk: add NPA aura create/destroy ROC
>> APIs')
>> Signed-off-by: Thierry Herbelot <thierry.herbelot at 6wind.com>
>> ---
>>   drivers/common/cnxk/roc_npa.c | 6 ++++--
>>   1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/common/cnxk/roc_npa.c
>> b/drivers/common/cnxk/roc_npa.c index 377439c2baaf..38e149da82cc
>> 100644
>> --- a/drivers/common/cnxk/roc_npa.c
>> +++ b/drivers/common/cnxk/roc_npa.c
>> @@ -245,8 +245,10 @@ npa_aura_fini(struct mbox *m_box, uint32_t
>> aura_id)
>>   	if (rc < 0)
>>   		goto exit;
>>
>> -	if (aura_rsp->hdr.rc != 0)
>> -		return NPA_ERR_AURA_POOL_FINI;
>> +	if (aura_rsp->hdr.rc != 0) {
>> +		rc = NPA_ERR_AURA_POOL_FINI;
>> +		goto exit;
>> +	}
>>
>>   	/* Sync NDC-NPA for LF */
>>   	ndc_req = mbox_alloc_msg_ndc_sync_op(mbox);
>> --
>> 2.39.2
> 

-- 
Thierry Herbelot
Senior Software Engineer
Tel: +33 1 39 30 92 61
http://www.6wind.com/

Follow us:
https://www.linkedin.com/company/6wind/
https://twitter.com/6WINDsoftware
https://www.youtube.com/user/6windsoftware