[EXT] [PATCH v3 9/9] crypto/mlx5: enable AES-GCM capability

[Suanming Mou]

> -----Original Message-----
> From: Akhil Goyal <gakhil at marvell.com>
> Sent: Tuesday, June 20, 2023 5:25 PM
> To: Suanming Mou <suanmingm at nvidia.com>; Matan Azrad
> <matan at nvidia.com>
> Cc: Raslan Darawsheh <rasland at nvidia.com>; dev at dpdk.org
> Subject: RE: [EXT] [PATCH v3 9/9] crypto/mlx5: enable AES-GCM capability
> 
> > This commit generates AES-GCM capability based on the NIC attributes
> > and enables AES-GCM algo.
> >
> > An new devarg "algo" is added to identify if the crypto PMD will be
> > initialized as AES-GCM(algo=1) or AES-XTS(algo=0, default).
> >
> > Signed-off-by: Suanming Mou <suanmingm at nvidia.com>
> 
> You should mention changelog for the changes done in the current patchset over
> previous one.
> It helps in review.

V1 is RFC, V1 compared to V2 was xts and gcm file split. V3 just did a minor fix in aes-gcm 256 key creation.
I put the change log in the cover-letter, but thanks for the suggestion, will update the change log in single patch as well.

> 
> Also update to "doc/guides/cryptodevs/features/mlx5.ini" is missing in this patch.

You are right, it is missing here.

> 
> Also get an ack from mlx5 crypto maintainer.
> 
> 
> > ---
> >  doc/guides/cryptodevs/mlx5.rst         | 48 +++++++++++++++++++-
> >  doc/guides/rel_notes/release_23_07.rst |  1 +
> >  drivers/crypto/mlx5/mlx5_crypto.c      | 26 +++++++++--
> >  drivers/crypto/mlx5/mlx5_crypto.h      |  1 +
> >  drivers/crypto/mlx5/mlx5_crypto_gcm.c  | 63
> > ++++++++++++++++++++++++++
> >  5 files changed, 134 insertions(+), 5 deletions(-)