[PATCH v4 01/34] common/sfc_efx/base: update MCDI headers

Ferruh Yigit ferruh.yigit at amd.com
Wed Jun 21 18:52:31 CEST 2023


On 6/7/2023 2:02 PM, Ivan Malov wrote:
> From: Denis Pryazhennikov <denis.pryazhennikov at arknetworks.am>
> 
> Pickup new FW interface definitions.
> 
> Signed-off-by: Denis Pryazhennikov <denis.pryazhennikov at arknetworks.am>
> Reviewed-by: Ivan Malov <ivan.malov at arknetworks.am>
> Reviewed-by: Andy Moreton <amoreton at xilinx.com>

<...>

> @@ -9127,15 +10514,13 @@
>  /***********************************/
>  /* MC_CMD_DYNAMIC_SENSORS_GET_DESCRIPTIONS
>   * Get descriptions for a set of sensors, specified as an array of sensor
> - * handles as returned by MC_CMD_DYNAMIC_SENSORS_LIST
> - *
> - * Any handles which do not correspond to a sensor currently managed by the MC
> - * will be dropped from from the response. This may happen when a sensor table
> - * update is in progress, and effectively means the set of usable sensors is
> - * the intersection between the sets of sensors known to the driver and the MC.
> - *
> - * On Riverhead this command is implemented as a a wrapper for
> - * `get_descriptions` in the sensor_query SPHINX service.
> + * handles as returned by MC_CMD_DYNAMIC_SENSORS_LIST. Any handles which do not
> + * correspond to a sensor currently managed by the MC will be dropped from from

typo "from from" fixed. This is reported by checkpatch.

> + * the response. This may happen when a sensor table update is in progress, and
> + * effectively means the set of usable sensors is the intersection between the
> + * sets of sensors known to the driver and the MC. On Riverhead this command is
> + * implemented as a wrapper for `get_descriptions` in the sensor_query SPHINX
> + * service.
>   */
>  #define	MC_CMD_DYNAMIC_SENSORS_GET_DESCRIPTIONS 0x67
>  #define	MC_CMD_DYNAMIC_SENSORS_GET_DESCRIPTIONS_MSGSET 0x67
> @@ -9173,19 +10558,15 @@
>  /***********************************/
>  /* MC_CMD_DYNAMIC_SENSORS_GET_READINGS
>   * Read the state and value for a set of sensors, specified as an array of
> - * sensor handles as returned by MC_CMD_DYNAMIC_SENSORS_LIST.
> - *
> - * In the case of a broken sensor, then the state of the response's
> - * MC_CMD_DYNAMIC_SENSORS_VALUE entry will be set to BROKEN, and any value
> - * provided should be treated as erroneous.
> - *
> - * Any handles which do not correspond to a sensor currently managed by the MC
> - * will be dropped from from the response. This may happen when a sensor table
> - * update is in progress, and effectively means the set of usable sensors is
> - * the intersection between the sets of sensors known to the driver and the MC.
> - *
> - * On Riverhead this command is implemented as a a wrapper for `get_readings`
> - * in the sensor_query SPHINX service.
> + * sensor handles as returned by MC_CMD_DYNAMIC_SENSORS_LIST. In the case of a
> + * broken sensor, then the state of the response's MC_CMD_DYNAMIC_SENSORS_VALUE
> + * entry will be set to BROKEN, and any value provided should be treated as
> + * erroneous. Any handles which do not correspond to a sensor currently managed
> + * by the MC will be dropped from from the response. This may happen when a

ditto, fixed "from from"



More information about the dev mailing list