[PATCH v3] doc: prefer installing using meson rather than ninja

Thomas Monjalon thomas at monjalon.net
Thu Jun 22 20:35:17 CEST 2023


09/06/2023 16:51, Bruce Richardson:
> After doing a build, to install DPDK system-wide our documentation
> recommended using the "ninja install" command. However, for anyone
> building as a non-root user and only installing as root, the "meson
> install" command is a better alternative, as it provides for
> automatically dropping or elevating privileges as necessary in more
> recent meson releases [1].
> 
> [1] https://mesonbuild.com/Installing.html#installing-as-the-superuser
> 
> Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
> 
> ---
> V3:
> * correct order of arguments to meson in CI scripts. The "-C" option
>   must follow the meson "install" command. [This is consistent with
>   other uses e.g. meson compile -C ..., meson test -C ...]
> 
> V2:
> * Fix one missed reference to "ninja install" in Linux GSG
> * Changed CI scripts to use "meson install" to ensure step is properly
>   tested.
> ---
>  .ci/linux-build.sh                           | 4 ++--
>  doc/guides/contributing/coding_style.rst     | 2 +-
>  doc/guides/cryptodevs/uadk.rst               | 2 +-
>  doc/guides/freebsd_gsg/build_dpdk.rst        | 2 +-
>  doc/guides/freebsd_gsg/build_sample_apps.rst | 2 +-
>  doc/guides/linux_gsg/build_dpdk.rst          | 4 ++--
>  doc/guides/prog_guide/build-sdk-meson.rst    | 4 ++--
>  7 files changed, 10 insertions(+), 10 deletions(-)

I see other occurences which could be replaced:

.ci/linux-build.sh:    [ -d install ] || DESTDIR=$(pwd)/install ninja -C build install
devtools/test-meson-builds.sh:  echo "DESTDIR=$2 $ninja_cmd -C $1 install" >&$verbose
devtools/test-meson-builds.sh:  DESTDIR=$2 $ninja_cmd -C $1 install >&$veryverbose
doc/guides/nics/mlx4.rst:    ninja install
doc/guides/platform/mlx5.rst:    ninja install





More information about the dev mailing list