[PATCH] drivers: remove compile-time option for IEEE 1588
Thomas Monjalon
thomas at monjalon.net
Sun Jun 25 17:45:52 CEST 2023
23/06/2023 16:00, Ferruh Yigit:
> On 2/3/2023 1:28 PM, Thomas Monjalon wrote:
> > The option RTE_LIBRTE_IEEE1588 has no effect on any library
> > unlike its name.
> >
> > Also we are suppose to enable/disable features dynamically,
> > not at compilation time.
> >
> > And the best is that this macro is neither documented,
> > nor in rte_config.h.
> >
> > It looks to be a mistake keeping this flag, so it is removed,
> > meaning always enabled.
> > PS: it is disabling vector paths of some drivers.
> >
>
> PTP (IEEE1588) processing brings additional overhead to datapath.
>
> Agree that it is not good to have undocumented compile macro, but just
> removing it may cause performance degradation.
>
> It may be possible to have separate burst function that supports PTP and
> driver configures it when application explicitly request it with a new
> offload flag (although it is not exactly an offload), what do you think?
The best is to enable dynamically with different functions.
More information about the dev
mailing list