[PATCH v1] net/mlx5: add test for hot upgrade
Thomas Monjalon
thomas at monjalon.net
Mon Jun 26 22:22:32 CEST 2023
16/05/2023 07:41, Rongwei Liu:
> This patch adds testpmd app a runtime function to test the hot
> upgrade API.
>
> testpmd> mlx5 set flow_engine <0|1> (flag)
> 0 stands for active mode while 1 for standby mode.
>
> Signed-off-by: Rongwei Liu <rongweil at nvidia.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo at nvidia.com>
> ---
> --- a/doc/guides/nics/mlx5.rst
> +++ b/doc/guides/nics/mlx5.rst
> @@ -2057,3 +2057,13 @@ where:
> * ``sw_queue_id``: queue index in range [64536, 65535].
> This range is the highest 1000 numbers.
> * ``hw_queue_id``: queue index given by HW in queue creation.
> +
> +Set Flow Engine Mode
> +^^^^^^^^^^^^^^^^^^^^
The title is made as a sub-section of "port map external Rx queue",
which looks wrong.
> +
> +Set the flow engine to active(0) or standby(1) mode with specific flags::
> + testpmd> mlx5 set flow_engine <0|1> (flags)
It should be said it is for testing live migration.
Also the flags are not described. Should we pass an integer?
> +
> +This command works for software steering only.
> +Default FDB jump should be disabled if switchdev is enabled.
> +The mode will propagate to all the probed ports.
For the reasons above, I prefer not pulling this patch in the main branch.
More information about the dev
mailing list