[PATCH] app: do not call printf in signal handlers

Thomas Monjalon thomas at monjalon.net
Wed Jun 28 02:44:09 CEST 2023


15/06/2023 22:14, Tyler Retzlaff:
> On Mon, Jun 12, 2023 at 05:11:50PM -0700, Stephen Hemminger wrote:
> > Using printf is not async-signal safe and worst case may lead to deadlock.
> > Remove printf from signal handlers present in several applications.
> > 
> > Testpmd was already fixed by
> > commit 0fd1386c30c3 ("app/testpmd: cleanup cleanly from signal")
> > 
> > Signed-off-by: Prateek Agarwal <prateekag at cse.iitb.ac.in>
> > Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
> > ---
> 
> Acked-by: Tyler Retzlaff <roretzla at linux.microsoft.com>

Applied, thanks for reviving this old patch.




More information about the dev mailing list