[PATCH v4 2/9] event/dlb2: skip configuration if no eventdev lib

David Marchand david.marchand at redhat.com
Thu Jun 29 11:39:53 CEST 2023


On Wed, Jun 28, 2023 at 12:19 PM David Marchand
<david.marchand at redhat.com> wrote:
>
> On Fri, Jun 23, 2023 at 5:07 PM Bruce Richardson
> <bruce.richardson at intel.com> wrote:
> >
> > While the build system will skip building most libs and drivers when a
> > dependency is missing for a component, for DLB2 driver, the
> > "static_rte_eventdev" object is referenced inside the meson.build file
> > itself, which will cause crashes if it doesn't exist i.e. if eventdev is
> > disabled. Prevent this issue by skipping processing the file if no
> > eventdev. [The build system will still report missing dependency, as the
> > dependency is set by default for all eventdev drivers]
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
>
> Could we evaluate the class "std_deps" before jumping to each driver
> meson.build?

Hum, with my suggestion, we lose the opportunity for drivers to
rewrite completely their "deps".
I doubt we have cases where it really matters, but if this revealed to
be necessary, such driver may be directly referenced in
drivers/meson.build like we do for common/cnxk & friends.

To illustrate the idea, I pushed your series along patches of mine
(target is v23.11) in my github repo.
https://github.com/david-marchand/dpdk/commit/enable_libs~8


-- 
David Marchand



More information about the dev mailing list