[PATCH v2 11/17] net/iavf: use previous value atomic fetch operations
Tyler Retzlaff
roretzla at linux.microsoft.com
Thu Mar 2 17:18:16 CET 2023
Use __atomic_fetch_{add,and,or,sub,xor} instead of
__atomic_{add,and,or,sub,xor}_fetch when we have no interest in the
result of the operation.
Reduces unnecessary codegen that provided the result of the atomic
operation that was not used.
Change brings closer alignment with atomics available in C11 standard
and will reduce review effort when they are integrated.
Signed-off-by: Tyler Retzlaff <roretzla at linux.microsoft.com>
Acked-by: Morten Brørup <mb at smartsharesystems.com>
---
drivers/net/iavf/iavf_vchnl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c
index 9adaadb..6c04bd2 100644
--- a/drivers/net/iavf/iavf_vchnl.c
+++ b/drivers/net/iavf/iavf_vchnl.c
@@ -128,7 +128,7 @@ struct iavf_event_handler {
int err = pipe(handler->fd);
#endif
if (err != 0) {
- __atomic_sub_fetch(&handler->ndev, 1, __ATOMIC_RELAXED);
+ __atomic_fetch_sub(&handler->ndev, 1, __ATOMIC_RELAXED);
return -1;
}
@@ -137,7 +137,7 @@ struct iavf_event_handler {
if (rte_ctrl_thread_create(&handler->tid, "iavf-event-thread",
NULL, iavf_dev_event_handle, NULL)) {
- __atomic_sub_fetch(&handler->ndev, 1, __ATOMIC_RELAXED);
+ __atomic_fetch_sub(&handler->ndev, 1, __ATOMIC_RELAXED);
return -1;
}
--
1.8.3.1
More information about the dev
mailing list