[PATCH] app/testpmd: fix closing softnic port before ethdev ports

Stephen Hemminger stephen at networkplumber.org
Thu Mar 9 17:31:09 CET 2023


On Thu,  9 Mar 2023 14:42:49 +0000
Yogesh Jangra <yogesh.jangra at intel.com> wrote:

> +		/*
> +		 * SoftNIC runs on the sevice core, it uses the resources from
> +		 * the testpmd application. When we run quit command, the testpmd
> +		 * application stops ethdev ports first, SoftNIC will try to
> +		 * access the port and sometimes that result in segmentation
> +		 * error. So first closing the SoftNIC port.
> +		 */
> +		RTE_ETH_FOREACH_DEV(pt_id) {
> +			if (!strcmp(ports[pt_id].dev_info.driver_name, "net_softnic")) {
> +				stop_port(pt_id);
> +				close_port(pt_id);
> +			}
> +		}
> +

NAK
No driver specific hacks please.

Instead fix the driver design or bug please.


More information about the dev mailing list