[PATCH] net/cpfl: refactor flow parser

[Zhang, Qi Z]

> -----Original Message-----
> From: Thomas Monjalon <thomas at monjalon.net>
> Sent: Monday, November 13, 2023 1:39 AM
> To: Qiao, Wenjing <wenjing.qiao at intel.com>; Zhang, Qi Z
> <qi.z.zhang at intel.com>
> Cc: Wu, Jingjing <jingjing.wu at intel.com>; Xing, Beilei <beilei.xing at intel.com>;
> dev at dpdk.org; Marchand, David <david.marchand at redhat.com>
> Subject: Re: [PATCH] net/cpfl: refactor flow parser
> 
> 07/11/2023 09:34, wenjing.qiao at intel.com:
> > From: Wenjing Qiao <wenjing.qiao at intel.com>
> >
> > Use strncpy instead of memcpy for string copy and rename macro.
> 
> I really wonder why memcpy was used for string copy.
> As you fix it, why not using strlcpy, as recommended by checkpatch?
> 
> Qi, why do you keep ignoring warnings reported in patchwork?

Have to nack this, there is no related patchwork error and warning was reported for the original patches.
https://patchwork.dpdk.org/project/dpdk/list/?series=29767&state=*

And I agree strlcpy is better than strncpy , thanks for the suggestion.




>