[PATCH v3 02/22] app/bbdev: replace strtok with reentrant version

Stephen Hemminger stephen at networkplumber.org
Wed Nov 15 01:09:34 CET 2023


On Tue, 14 Nov 2023 18:59:46 +0800
Jie Hai <haijie1 at huawei.com> wrote:

> Multiple threads calling the same function may cause condition
> race issues, which often leads to abnormal behavior and can cause
> more serious vulnerabilities such as abnormal termination, denial
> of service, and compromised data integrity.
> 
> The strtok() is non-reentrant, it is better to replace it with a
> reentrant version.
> 
> Fixes: 0acdb9866756 ("test/bbdev: add FFT operations cases")
> Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Jie Hai <haijie1 at huawei.com>
> Acked-by: Chengwen Feng <fengchengwen at huawei.com>

NAK
Please don't make wide assertions about multi-threading.
All these are only called from test_bbdev_vector_read which is single
threaded.

Please limit patches to places where you are sure the use is multi-threaded.


More information about the dev mailing list